bruns added inline comments.
INLINE COMMENTS
> knewfilemenu.cpp:873
> +
> + KMessageBox::createKMessageBox(confirmDialog, buttonBox,
> QMessageBox::Warning,
> + i18n("Cannot create directory with name
> \"%1\"", name),
Should be QMessageBox::Error in this case
> ngraham wrote in knewfilemenu.cpp:874
> This message might be a little bit too terse. How about something that helps
> explain the reason as well, like this?
>
> > "<name>" has a special meaning for the operating system and cannot be used
> > as the name for a folder.
> Folder "<name> could not be created:
> "<name>" is reserved for use by the operating system.
We should probably use an error message similar to the one returned from the
KIO job in case something goes wrong.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D13805
To: tmarshall, #dolphin, #frameworks
Cc: bruns, ngraham, kde-frameworks-devel, michaelh, spoorun, navarromorales,
isidorov, firef, andrebarros, emmanuelp
