cfeck accepted this revision. cfeck added a comment. This revision is now accepted and ready to land.
I was thinking if we need general support for .ico files on Windows, but fear a slowdown while lookup of theme icons. But if this works for the special case of full-path icons, we can revisit the issue once/if we get a separate ticket. REPOSITORY R302 KIconThemes BRANCH ico-support-in-icon-file-chooser-dialog (branched from master) REVISION DETAIL https://phabricator.kde.org/D13718 To: ngraham, #frameworks, cfeck Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns