leinir requested changes to this revision. leinir added a comment. This revision now requires changes to proceed.
Autotests are good, but so is documentation - in principle this is good, but new public functions without documentation isn't really acceptable :) Apart from that, though, looks good! :) (was just about to add a comment about your invalid data string being less than descriptive... but hey, it's invalid data, why not ;) ) INLINE COMMENTS > provider.h:275 > > + ItemJob<Config> *requestConfig(); > + When adding new functions to anywhere, putting in documentation really needs to happen as well :) You've got it in other places already, though, so i'm sure that's just a minor bit of forgetfulness, these things happen :) REPOSITORY R235 Attica REVISION DETAIL https://phabricator.kde.org/D13733 To: habacker, leinir Cc: kde-frameworks-devel, michaelh, ngraham, bruns
