vandenoever accepted this revision.
vandenoever added a comment.
This revision is now accepted and ready to land.
Good fixes. Just some small naming suggestions.
INLINE COMMENTS
> odfextractor.cpp:37
> +
> +QDomElement namedItemNS(const QDomNode &node, const QString &nsURI, const
> QString &localName)
> +{
Perhaps name this `elementByTagNameNS`.
> odfextractor.cpp:39
> +{
> + for (auto n = node.firstChildElement(); !n.isNull(); n =
> n.nextSiblingElement()) {
> + if (n.localName() == localName && n.namespaceURI() == nsURI) {
Variable name `e` for element is more logical.
REPOSITORY
R286 KFileMetaData
BRANCH
noncommonprefixodf
REVISION DETAIL
https://phabricator.kde.org/D13719
To: kossebau, vandenoever
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun,
ngraham, bruns, abrahams
