bruns added a comment.
In D13216#275546 <https://phabricator.kde.org/D13216#275546>, @smithjd wrote: > In D13216#275538 <https://phabricator.kde.org/D13216#275538>, @bruns wrote: > > > @smithjd You have probaly become another victim of phabricator/arc. Your commits have been squashed by arc ... > > If you wan't your commits to stay separated, you have to do a `git checkout` of the first commit, do a `arc diff HEAD^1`, checkout the next commit, `arc diff HEAD^1`, and so on. > > > Commits are squashed on arc land anyway, but the branch can be manually pushed keeping the separate patches. If you mean separated into different reviews, I don't think it's unclear why there are small changes to code related to the scheduler, or why it might be advantageous to separate these into different reviews. > > Is there any practical reason why a simple arc land wouldn't suffice here? Because pushing independent stuff in a single commit just sucks for the reviewer, and it sucks if you want to understand the git history later. You are changing 5 different things in your patches. I can not see which changed source line relates to which change. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13216 To: smithjd, bruns, mgallien Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns
