ngraham added a subscriber: cfeck. ngraham added a comment.
In D12756#268311 <https://phabricator.kde.org/D12756#268311>, @cfeck wrote: > I will not block this change, but cannot approve it either. > > Reasons: > > - The pure red is looks too saturated, as if something dangerous is about to happen. Maybe add the VDG as a reviewer. I understand, and agree. I'm also not sure that red is the right color here in the first place. > - We should not use hardcoded colors on varying backgrounds. While the chance that someone uses Qt::red as a background color is zero, the code _should_ handle the dark vs. bright case as stated in the bug report. OK, I'll implement that part at least (even if for now we keep the colors identical, whatever we choose). REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D12756 To: ngraham, #frameworks Cc: cfeck, kde-frameworks-devel, mwolff, apol, michaelh, ngraham, bruns
