mart accepted this revision.
mart added a comment.
This revision is now accepted and ready to land.
Restricted Application edited subscribers, added: kde-frameworks-devel;
removed: Frameworks.
good to go, modulo that possible little code comment more
INLINE COMMENTS
> kossebau wrote in metadata.desktop:88
> Ideally the kapptemplate system would have support for an organization domain
> parameter which then could be used here (on my notes for some kapptemplatev2).
>
> For now this brush-over is proposed with KDE community contributors in mind,
> to help them getting applets properly prepared e.g. with integration into KDE
> translations right from the begin.
>
> Any 3rd-party which wants to keep their plasmoid 3rd-party would need to
> adapt the org namespace as desired, which I would expect them to do anyway if
> they are proud of their org.
maybe add a # comment on top of that line staing this?
> kossebau wrote in %{APPNAMELC}plugin.cpp:33
> Yes, not completly sure about this one.
> But having seen people not getting translation setup correctly, it felt
> better to add the include and ki18n linking from the start, as removing those
> lines is easier then adding them correctly.
> So I would make an exception here for ki18n. But maintainers call, just
> proposing.
yeah, i agree that i18n is kinda "special" and can make sense to be kept
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
brushovertemplates
REVISION DETAIL
https://phabricator.kde.org/D10848
To: kossebau, mart
Cc: kde-frameworks-devel, apol, michaelh, ngraham, bruns, #frameworks
