ngraham marked 2 inline comments as done. ngraham added inline comments. INLINE COMMENTS
> rkflx wrote in kdiroperator.cpp:1888 > I think it is a misconception that toolbar icons represent state. I don't > know of any toolbar in our software where this is the case, so why should > users suddenly expect that what's on the icon represents exactly what is > happening, e.g. A-Z ascending? It is merely an example of what type of > actions they can expect when clicking on the button. > > Icons are a symbolic representation of general concept, not a literal display > of a specific state. > > --- > > Anyway, if you want block everything on that, that's what we'll do. Seems like the new icon may be a long time in coming, and after giving it more thought, I've come around to your position (an increasingly common occurrence! :) ). REPOSITORY R241 KIO BRANCH arcpatch-D12337 REVISION DETAIL https://phabricator.kde.org/D12337 To: ngraham, #frameworks, #dolphin, #vdg, rkflx Cc: kde-frameworks-devel, andreaska, markg, broulik, anemeth, michaelh, ngraham, bruns