graesslin added inline comments.
Restricted Application added a subscriber: kde-frameworks-devel.

INLINE COMMENTS

> outputchangeset.cpp:91
>  }
> +
>  bool OutputChangeSet::positionChanged() const

nitpick: added unrelated new line

> outputdevice_interface.cpp:427
> +
> +    org_kde_kwin_outputdevice_send_colorcurves(data.resource, &wlRed, 
> &wlGreen, &wlBlue);
> +

you need to do a version check and only send to clients which have the required 
version. A FOO_SINCE macro should be defined by the generated wayland header.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D12388

To: romangg, #frameworks, davidedmundson, graesslin
Cc: kde-frameworks-devel, graesslin, davidedmundson, zzag, cfeck, michaelh, 
ngraham, bruns

Reply via email to