apol added inline comments.
INLINE COMMENTS
> telegramplugin.cpp:53
> + foreach(const QJsonValue& val, array) {
> + ret += toPath(val.toString());
> + }
toUrl().toLocalFile().
Also I would Check if(url.isLocalFile()).
> telegramplugin.cpp:61
> + QProcess* process = new QProcess(this);
> + process->setProgram(QStringLiteral("telegram-desktop"));
> + QJsonArray urlsJson =
> data().value(QStringLiteral("urls")).toArray();
Instead of finding the program, we could execute using
`org.telegram.desktop.desktop`, it would allow it to work even if it's
installed from appimage/flatpak.
I'm not sure how this would work without bumping the tier.
> telegramplugin.cpp:63
> + QJsonArray urlsJson =
> data().value(QStringLiteral("urls")).toArray();
> + qCDebug(PLUGIN_TELEGRAM()) << "Foo" << urlsJson;
> + process->setArguments(QStringList(QStringLiteral("-sendpath"))
> << arrayToList(urlsJson));
Fix or remove debug message.
REPOSITORY
R495 Purpose Library
REVISION DETAIL
https://phabricator.kde.org/D12896
To: nicolasfella, apol
Cc: ngraham, kde-frameworks-devel, apol, michaelh, bruns
