dhaumann added a comment.
Somehow my other comments were lost, here we go: - could you also update the screenshot in the doxygen documentation? - setIcon() is behavior incompatible, and in fact, the referenced bugs did not complain about icons. So why the change? In my opinion this is not good enough in case of Kate/KWrite. - setIcon(): Now the API documentation in the header file is wrong, since it says by default no icon is set. @ngraham Could we have another revision? REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D12508 To: ngraham, hein, #plasma, #vdg, cfeck Cc: kde-frameworks-devel, dhaumann, broulik, anemeth, abetts, cfeck, mart, fabianr, elvisangelaccio, jnoack, michaelh, ngraham, bruns
