ngraham added a comment.
Nice! Behaviorally, this works well now and I didn't find any regressions. Just some code style comments below: INLINE COMMENTS > kfilewidget.cpp:1189 > } > + > } Unnecessary unrelated whitespace change > kfilewidget.cpp:1866 > + > + connect(d->ops->view(), SIGNAL(doubleClicked(QModelIndex)), this, > SLOT(_k_slotViewDoubleClicked(QModelIndex))); > } Let's use new-style signal/slot syntax for new code. See https://wiki.qt.io/New_Signal_Slot_Syntax REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12538 To: anemeth, #frameworks, #vdg, ngraham, rkflx Cc: kde-frameworks-devel, ltoscano, rkflx, broulik, jtamate, ngraham, #frameworks, michaelh, bruns
