ngraham added a comment.
In D12327#255621 <https://phabricator.kde.org/D12327#255621>, @elvisangelaccio wrote: > FWIW I also disagree with D12077 <https://phabricator.kde.org/D12077>. I don't see why we should show only two buttons (for short and detailed tree view), when we have four view modes. Because IMHO only two of them actually make sense the file dialogs. `KDirOperator` is flexible by design, and there is no reason to expose all of its functionality. For example Tree View is completely pointless in the file dialogs, because we have enough horizontal space to show the superior Detailed Tree View instead. Detailed View and Detailed Tree View differ only in that the latter allows the folders to be expanded. I'm honestly fine with either one being featured as one of our two toolbar buttons but I don't think it makes sense to have them both visible as toolbar buttons given the very small differences between them. At one point I think @rkflx proposed collapsing them into a single mode with a checkbox for "allow expansion", as Dolphin has. I would be in favor of this if it's technically feasible. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12327 To: ngraham, #frameworks, #vdg, rkflx Cc: elvisangelaccio, abetts, #frameworks, michaelh, bruns
