ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed.
This is clearly what the code was //trying// to do, based on inline comments: https://cgit.kde.org/kio.git/tree/src/filewidgets/kfilewidget.cpp#n1176 However, are we sure this is the right fix? This will have the effect of adding the select-text-when-clicked behavior the Open dialogs too, which does not seem to have been intended and which I don't think is helpful. Perhaps we should change the `locationEdit->setFocus();` to `locationEdit->lineEdit()->setFocus();` on line 1179 instead. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12545 To: anemeth, #frameworks, #vdg, ngraham Cc: ngraham, #frameworks, michaelh, bruns
