broulik added inline comments. INLINE COMMENTS
> documenturldb.cpp:107 > { > - Q_ASSERT(id > 0); > - Q_ASSERT(!name.isEmpty()); > + if (!docId || name.isEmpty()) { > + return; Didn't you mean `id`? > documenturldb.cpp:172 > { > - Q_ASSERT(docId > 0); > + if (newFileName.isEmpty() || !docId) { > + return; Put `docId` check first for consistency REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12336 To: bruns, #baloo, michaelh, #frameworks Cc: broulik, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, bruns