ngraham added a comment.
I do feel like I get Mark's point and sympathize with the impulse behind it: there's the potential for user frustration when a feature is unexpectedly unavailable, or a button doesn't do anything when you click it. It's like the Fit and Fill buttons in Gwenview when "Enlarge Images" is turned off: you click on them, nothing happens, and you don't know why and feel irritated about it. Now, it's better here since we're actually //disabling// the button when its feature can't be used, and we show a helpful tooltip on hover that explains why. We might consider doing those for Gwenview too. If and when this feature lands in both the open/save dialogs and also Dolphin, I don't really expect any user complaints, but if they do arise, we can investigate adding a setting to control the "disable previews at small sizes" with a setting in Dolphin's Previews tab (until we can relocate those settings to somewhere in System Settings). I'm not a fan of tri-state buttons, as they're terribly baffling to most users. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12321 To: anemeth, #vdg, #frameworks, ngraham, rkflx, #dolphin, markg Cc: elvisangelaccio, markg, xyquadrat, sharvey, rkflx, ngraham, #frameworks, michaelh, bruns
