elvisangelaccio requested changes to this revision.
elvisangelaccio added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> ngraham wrote in jobuidelegate.cpp:229
> Couldn't get `<nl/>` working, so I hope `<p>` tags are okay.
Nope, see the following warnings:
"Tag 'p' is not defined in message {<__kuit_internal_top__><p>Do you really
want to permanently delete this item?</p...}."
"Tag 'p' is not defined in message {<__kuit_internal_top__><p>Do you really
want to permanently delete this item?</p...}."
"Tag 'b' is not defined in message {<__kuit_internal_top__><p>Do you really
want to permanently delete this item?</p...}."
What we need is to use `xi18ncp()` with `@info` as context, `<nl/>` instead of
`<p></p>` and `<emphasis strong='true'></emphasis>` instead of `<b></b>`.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D12420
To: ngraham, #frameworks, #dolphin, elvisangelaccio
Cc: michaelh, bruns
