jtamate added inline comments.
INLINE COMMENTS
> pendingfilequeue.cpp:68
> + const auto startRemoving = std::partition(m_cache.begin(), end,
> isDescendant);
> + for (auto it = startRemoving; it != end; it++) {
> + m_pendingFiles.remove(it->path());
According to std::partition
<http://en.cppreference.com/w/cpp/algorithm/partition>
what matches isDescendant should be from m_cache.begin() up to startRemoving,
unless you want to remove what does not match isDescendant, isn't it?
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D12233
To: michaelh, #baloo
Cc: jtamate, bruns, #frameworks, ashaposhnikov, michaelh, astippich, spoorun
