joselema created this revision. joselema added reviewers: graesslin, hein, sharvey. joselema added a project: Frameworks. Restricted Application added a subscriber: Frameworks. joselema requested review of this revision.
REVISION SUMMARY Hi, I think since this change: https://phabricator.kde.org/D11924 we are having this regression in autotests for kwindowsystem: FAIL! : NetRootInfoTestWM::testSupported() Compared values are not the same Actual (supportedReply->value_len): 88 Expected (uint32_t(count)) : 87 Loc: [/home/jenkins/workspace/Plasma kwindowsystem kf5-qt5 SUSEQt5.9/autotests/netrootinfotestwm.cpp(271)] so I'm attaching a possible patch for this issue, please be careful because I don't fully understand the code involved. Regards. P.S. After the SkipSwticher change there's other regresssion for other test: FAIL! : KWindowInfoX11Test::testState(skipSwitcher) Compared values are not the same Loc: [/home/jenkins/workspace/Plasma kwindowsystem kf5-qt5 SUSEQt5.9/autotests/kwindowinfox11test.cpp(230)] I don't know very well how to solve that one, in Kubuntu's packaging we are just disabling the failing check it like this: --- a/autotests/kwindowinfox11test.cpp +++ b/autotests/kwindowinfox11test.cpp @@ -197,7 +197,7 @@ void KWindowInfoX11Test::testState_data( QTest::newRow("shaded") << NET::States(NET::Shaded); QTest::newRow("skipTaskbar") << NET::States(NET::SkipTaskbar); QTest::newRow("skipPager") << NET::States(NET::SkipPager); - QTest::newRow("skipSwitcher") << NET::States(NET::SkipSwitcher); + //QTest::newRow("skipSwitcher") << NET::States(NET::SkipSwitcher); QTest::newRow("keep above") << NET::States(NET::KeepAbove); QTest::newRow("keep below") << NET::States(NET::KeepBelow); QTest::newRow("fullscreen") << NET::States(NET::FullScreen); TEST PLAN Tested the patch building from git master and also adding it to Kubuntu's packaging, either way it fixes the regression for me. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D12363 AFFECTED FILES autotests/netrootinfotestwm.cpp To: joselema, graesslin, hein, sharvey Cc: rikmills, #frameworks, michaelh, bruns
