bruns requested changes to this revision.
bruns added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> databasesanitizer.cpp:166
>
> -private:
> Transaction* m_transaction;
Why do you remove the private: here?
> databasesanitizer.cpp:176
> + quint64 id = 0;
> + };
> + IdInfo toIdInfo(quint64 id) {
Is this struct still used?
> databasesanitizer.cpp:184
> + return result;
> + }
> +
duplicates code from idutils.h
> databasesanitizer.cpp:326
> + }
> + }
> + return result;
Restructure:
Iterate over listResult.first to populate with deviceIds
Iterate over result to set each entry to ignore/use.
> databasesanitizer.cpp:343
> + }
> + out << sep << QStringLiteral("device: %1").arg(info.deviceId)
> + << sep << QStringLiteral("inode: %1").arg(info.inode)
remove `sep`, use `QStringLiteral(" device: %1") instead
> databasesanitizer.cpp:344
> + out << sep << QStringLiteral("device: %1").arg(info.deviceId)
> + << sep << QStringLiteral("inode: %1").arg(info.inode)
> + << sep << QStringLiteral("url: %1").arg(info.url)
dito `sep`, indent to align `<<` with line above
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D11753
To: michaelh, #baloo, #frameworks, bruns
Cc: bruns, cfeck, smithjd, ashaposhnikov, michaelh, astippich, spoorun,
ngraham, alexeymin
