ngraham created this revision. ngraham added reviewers: Frameworks, rkflx. Restricted Application added a project: Frameworks. ngraham requested review of this revision.
REVISION SUMMARY According to a comment in the code, Open With was never supposed to show up for folders in the first place, but a bug prevented this wrom working: the value of `firstItem.url().isLocalFile()` was also checked, but this always returns true for local directories, not just local files. Removing that check--and the code supporting it--fixes the issue. TEST PLAN Open With entries... - Appear for local and remote files and symlinks to files - Do not appear for local and remote folders and symlinks to folders Examples: [Example images go here] REPOSITORY R241 KIO BRANCH no-open-with-for-folders (branched from master) REVISION DETAIL https://phabricator.kde.org/D12206 AFFECTED FILES src/widgets/kfileitemactions.cpp To: ngraham, #frameworks, rkflx Cc: michaelh, ngraham, bruns
