bruns added inline comments.

INLINE COMMENTS

> michaelh wrote in orpostingiterator.cpp:71
> Newbie question: Does std::unique_ptr make sense here?

When writing from scratch today, yes.
But this would not disallow nullptr 
(`std::make_unique<PostingIterator>(nullptr)` is fully valid)

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11828

To: bruns, #baloo, michaelh
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, 
alexeymin

Reply via email to