meven added a comment.

  In term of comparison to the FileCopyJob for instance, the difference I can 
spot with the DeleteJob implementation, is that the FileCopyJobPrivate itselft 
instanciates a subJob in this case a DirectCopyJob that will do the work, using 
internally SimpleJobPrivate.
  This internal SimpleJobPrivate is executed in a slave thread as I understand, 
allowing the UI thread to run during the file copy.
  
  I guess the right way to fix that would be to refactor the delete operation 
in the same manner: using a SimpleJob to benefit from the slave thread, the Job 
API provides.
  
  The downside is that it requires much more code editing.
  Does it make sense ?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10702

To: meven, #frameworks, dfaure, ngraham, #dolphin, jtamate
Cc: jtamate, markg, ngraham, #frameworks, michaelh, bruns

Reply via email to