bruns created this revision. bruns added reviewers: Baloo, michaelh. Restricted Application added projects: Frameworks, Baloo. Restricted Application added a subscriber: Frameworks. bruns requested review of this revision.
REVISION SUMMARY The code merged compatible terms only if the left hand side was a list of subterms (i.e. it worked for "a AND b AND (c AND d)", but not "b AND (c AND d)"). Instead of duplicating code, just use the Term(Term, Operation, Term) constructor, which handles merging. REPOSITORY R293 Baloo BRANCH baloo_term_cleanup_2 REVISION DETAIL https://phabricator.kde.org/D12005 AFFECTED FILES autotests/unit/lib/advancedqueryparsertest.cpp src/lib/advancedqueryparser.cpp To: bruns, #baloo, michaelh Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin
