michaelh requested changes to this revision.
michaelh added a comment.
This revision now requires changes to proceed.
Except for the white space stuff I'm still fine with this.
INLINE COMMENTS
> taglibextractor.cpp:237
> data.discNumber = itDiscNumber->second.toInt();
> + } TagLib::MP4::ItemListMap::Iterator itCompilation =
> allTags.find("cpil");
> + if (itCompilation != allTags.end()) {
New line please
> taglibextractor.cpp:304
>
> + // Genre.
> itMPC = lstMusepack.find("GENRE");
Nitpick: These comments aren't really informative. The tagname is explicit
enough.
I don't mind if you leave them in.
> taglibextractor.cpp:659
> extractOgg(stream, mimeType, data);
> +
> }
Unrelated white-space change
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D10803
To: astippich, mgallien, ngraham, michaelh
Cc: vhanda, dfaure, michaelh, ngraham, #frameworks, ashaposhnikov, astippich,
spoorun, nicolasfella, alexeymin
