dfaure accepted this revision.
dfaure added a comment.

  Thanks !
  
  Do you have a contributor account for pushing the commit, or do you need 
someone else to do it?

INLINE COMMENTS

> markg wrote in file_unix.cpp:546-550
> I "think" it belongs in createUDSEntry, but i'm not sure either. It would 
> keep this else nice and clean. But i do see why you'd want to put it here... 
> What's your take on this, @dfaure?

Looks fine to me here, due to the file.cpp / file_unix.cpp split.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11204

To: rominf, #dolphin, #frameworks, markg, dfaure
Cc: dfaure, markg, elvisangelaccio, ltoscano, anthonyfieroni, broulik, 
#frameworks, #dolphin, michaelh, ngraham

Reply via email to