bshah added inline comments.

INLINE COMMENTS

> kossebau wrote in KF5PackageMacros.cmake:164
> Does a plain `${KDE_INSTALL_DATADIR}` not also work? The non-FULL variable 
> variants are the ones used usually with `install()`. Not exactly sure why 
> they are, but doing here as well would be consistent at least and less 
> surprising.

I'll create seperate PR for that.

REPOSITORY
  R290 KPackage

REVISION DETAIL
  https://phabricator.kde.org/D11642

To: bshah, mart, davidedmundson, apol
Cc: kossebau, #frameworks, michaelh, ngraham

Reply via email to