ngraham created this revision. ngraham added reviewers: rkflx, VDG, Frameworks, Dolphin. Restricted Application added a project: Frameworks. ngraham requested review of this revision.
REVISION SUMMARY This patch adjusts the Open With UI to improve the strings and display apps inline (without a sub-menu) when there are four or fewer. This presents the following advantages over the status quo: - All the open with menu items form a complete sentence: "Open With Gwenview"; "Open With Application..."; "Open With Other Application..."; "Open With > Other Application..." - We only use a sub-menu when there are more than 4 entries (which is when the inline app list would start to become unmanageable). This improves speed and usability, since sub-menus are slow and error-prone for all but expert mousers TEST PLAN - Right-click on a folder in Dolphin: - Right-click on an image in Dolphin when there are 4 image handlers registered: - Right-click on an image in Dolphin when there are 5 image handlers registered: - Click on any of the menu items in the above cases; all work - Opened Gwenview > navigated to an image > right-click: no change, Gwenview uses a custom implementation in `fileopscontextmanageritem.cpp` rather than this nice API, boo REPOSITORY R241 KIO BRANCH open-with-usability (branched from master) REVISION DETAIL https://phabricator.kde.org/D11569 AFFECTED FILES src/widgets/kfileitemactions.cpp To: ngraham, rkflx, #vdg, #frameworks, #dolphin Cc: michaelh, ngraham
