davidk added a comment.
In D8532#215476 <https://phabricator.kde.org/D8532#215476>, @michaelh wrote: > I don't know Seccomp. But as far as I understood this, the same concers apply to the `baloo_file_temp_extractor` baloo-widgets is using. Naivly I suggest to implement this KFileMetadata because both executables are using it. I don't know if that is possible or reasonable though. I think Seccomp would be usefull in the `baloo_file_temp_extractor` too. What API would you suggest? I think on something like KFileMetaData::setProcessReadOnly(KFileMetaData::SeccompAction action, QList<KFileMetaData::SeccompFilter> addionalWhitelist) This would be a whitelist approach, so we would need to make sure we have good autotests. The autotests should be in KFileMetaData (fairly easy) and in `baloo_file{,temp}_extractor`. I would try to make an integration test, which starts up the `baloo_file{,temp}_extractor` and let's it index an directory containing test files. It would be good to use the KFileMetadata/autotests/samplefiles directory, but I'm not sure how to do this, without copying it. Do you have any ideas about this? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D8532 To: davidk, apol, ossi Cc: michaelh, #baloo, detlefe, ngraham, nicolasfella, #frameworks, ashaposhnikov, astippich, spoorun, alexeymin
