mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> databasesanitizer.cpp:46
> + public:
> + FileInfo(const quint32 d = 0, const quint32 i = 0,
> + const QString& u = QString(), const bool a = true)
you can replace this constructor by initialize directly variable
> bool accessible = true;
=========================
etc.
> it avoids to create this constructor
======================================
> databasesanitizer.cpp:99
> + QVector<quint32> excludeIds;
> + for (const auto& deviceId : deviceIds) {
> + if (deviceId > 0) {
const auto & for a quint32
it's better to use directly quint32 without const'ref
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D11285
To: michaelh, #baloo, #frameworks, ngraham, mlaurent
Cc: mlaurent, ngraham, smithjd, ashaposhnikov, michaelh, astippich, spoorun,
nicolasfella, alexeymin
