D11331: add gaming_input devices and others to Battery

Thu, 15 Mar 2018 14:30:33 -0700 

dollinger updated this revision to Diff 29636.
dollinger added a comment.


  I'm not sure where to add that enum you mentioned since there is already one 
in `frontend\battery.h`:
  
    enum BatteryType { UnknownBattery, PdaBattery, UpsBattery,
                       PrimaryBattery, MouseBattery, KeyboardBattery,
                       KeyboardMouseBattery, CameraBattery,
                       PhoneBattery, MonitorBattery
                     };
  
  But what we need is:
  
    typedef enum {
        UP_DEVICE_KIND_UNKNOWN,
        UP_DEVICE_KIND_LINE_POWER,
        UP_DEVICE_KIND_BATTERY,
        UP_DEVICE_KIND_UPS,
        UP_DEVICE_KIND_MONITOR,
        UP_DEVICE_KIND_MOUSE,
        UP_DEVICE_KIND_KEYBOARD,
        UP_DEVICE_KIND_PDA,
        UP_DEVICE_KIND_PHONE,
        UP_DEVICE_KIND_MEDIA_PLAYER,
        UP_DEVICE_KIND_TABLET,
        UP_DEVICE_KIND_COMPUTER,
        UP_DEVICE_KIND_GAMING_INPUT,
        UP_DEVICE_KIND_LAST
    } UpDeviceKind;

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11331?vs=29504&id=29636

REVISION DETAIL
  https://phabricator.kde.org/D11331

AFFECTED FILES
  src/solid/devices/backends/upower/upowerdevice.cpp

To: dollinger, broulik, #plasma
Cc: aleksejshilin, #frameworks, michaelh, ngraham

Reply via email to