michaelh added inline comments.
INLINE COMMENTS
> taglibextractor.cpp:219
>
> - // Handling multiple tags in Ogg containers.
> - {
No `if` here
> astippich wrote in taglibextractor.cpp:331
> Yes, but imho we shouldn't even enter the function for mimetypes not having
> ogg tags. Maybe that is overly careful
I think it is. At this point only `ogg`, `flac` and `opus` should be left.
Also I only refactored and didn't change the logic, unless I made a mistake
that is.
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D10918
To: michaelh, mgallien, #baloo, #frameworks, astippich
Cc: astippich, ashaposhnikov, michaelh, spoorun, nicolasfella, ngraham,
alexeymin
