aleksanderm added a comment.

  In D11320#225486 <https://phabricator.kde.org/D11320#225486>, @broulik wrote:
  
  > Is that custom marshaller even neccessary? I thought Qt could resolve QList 
and QVariantMap (even nested) automatically? Can you try just removing that 
entire thing?
  
  
  Unless I'm missing something, it seems that it really is needed, this is what 
I got when removing the custom marshallers for QVariantMapList:
  
    CMakeFiles/KF5ModemManagerQt.dir/bearer.cpp.o: In function 
`QList<QMap<QString, QVariant> > qdbus_cast<QList<QMap<QString, QVariant> > 
>(QDBusArgument const&, QList<QMap<QString, QVariant> >*)':
    
bearer.cpp:(.text._Z10qdbus_castI5QListI4QMapI7QString8QVariantEEET_RK13QDBusArgumentPS6_[_Z10qdbus_castI5QListI4QMapI7QString8QVariantEEET_RK13QDBusArgumentPS6_]+0x3e):
 undefined reference to `operator>>(QDBusArgument const&, QList<QMap<QString, 
QVariant> >&)'
    CMakeFiles/KF5ModemManagerQt.dir/generictypes.cpp.o: In function `void 
qDBusMarshallHelper<QList<QMap<QString, QVariant> > >(QDBusArgument&, 
QList<QMap<QString, QVariant> > const*)':
    
generictypes.cpp:(.text._Z19qDBusMarshallHelperI5QListI4QMapI7QString8QVariantEEEvR13QDBusArgumentPKT_[_Z19qDBusMarshallHelperI5QListI4QMapI7QString8QVariantEEEvR13QDBusArgumentPKT_]+0x1f):
 undefined reference to `operator<<(QDBusArgument&, QList<QMap<QString, 
QVariant> > const&)'
    CMakeFiles/KF5ModemManagerQt.dir/generictypes.cpp.o: In function `void 
qDBusDemarshallHelper<QList<QMap<QString, QVariant> > >(QDBusArgument const&, 
QList<QMap<QString, QVariant> >*)':
    
generictypes.cpp:(.text._Z21qDBusDemarshallHelperI5QListI4QMapI7QString8QVariantEEEvRK13QDBusArgumentPT_[_Z21qDBusDemarshallHelperI5QListI4QMapI7QString8QVariantEEEvRK13QDBusArgumentPT_]+0x1f):
 undefined reference to `operator>>(QDBusArgument const&, QList<QMap<QString, 
QVariant> >&)'
    collect2: error: ld returned 1 exit status

REPOSITORY
  R281 ModemManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D11320

To: aleksanderm, #frameworks, jgrulich
Cc: broulik, michaelh, ngraham

Reply via email to