kossebau added a comment.
Questions had been: A) names of macro and arguments okay? B) other/similar/related use cases which should be covered? C) how to design argument passing for all the arg1, arg2, arg3? Is the currrent approach sane or how to support someone needing some arg5? No answers all the time mapped to: current approach okay :) For usage & purpose of this macro see D11294 <https://phabricator.kde.org/D11294>, D11295 <https://phabricator.kde.org/D11295>, D11296 <https://phabricator.kde.org/D11296> Also related: - intermediate non-ecm-macro-based fixes for KF5 modules by D10733 <https://phabricator.kde.org/D10733>, D10732 <https://phabricator.kde.org/D10732>, D10724 <https://phabricator.kde.org/D10724> - related CMake issue https://gitlab.kitware.com/cmake/cmake/issues/17750 Would push Monday, March 19th if no-one objects or has some comment. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D10749 To: kossebau, #build_system, #frameworks Cc: michaelh
