davidedmundson added a comment.
Copying our IRC chat: I tried something /very very/ similar https://phabricator.kde.org/D8495?vs=on&id=21368&whitespace=ignore-most#toc which merges queryDeviceInterface into the earlier query. It didn't work. This patch is a bit different, it does a coarse filter, then still goes through queryDeviceInterface afterwards. My concern with this is that your filter query for PortableMediaPlayer doesn't match what queryDeviceInterface(PortableMediaPlayer) does. That code does "devicesByProperty("ID_MEDIA_PLAYER", QVariant()" If you can prove that property is only valid for USB subsystems, then you can ship it, otherwise, no. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D11290 To: broulik, #frameworks, davidedmundson Cc: ngraham, michaelh
