anthonyfieroni added inline comments.
INLINE COMMENTS
> kfileitem.cpp:1116-1136
> + constexpr size_t xattr_size = 1024;
> + char strAttr[xattr_size];
> + length = getxattr(fileName, attrName, strAttr, xattr_size);
> + if (length <= 0) {
> + return false;
> + }
> +
Indeed this should be done in different way, about me
std::uint64_t attr;
length = getxattr(fileName, attrName, &attr, sizeof attr);
if (length <= 0) {
return false;
}
> kfileitem.cpp:1136
> + auto intAttr = static_cast<uint>(strtol(hexAttr, nullptr, 16));
> + delete hexAttr;
> +
It should be
delete[] hexAttr;
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D11204
To: rominf, #dolphin, #frameworks
Cc: anthonyfieroni, broulik, #frameworks, #dolphin, michaelh
