dfaure added inline comments.
INLINE COMMENTS
> jtamate wrote in kurlcompletion.cpp:626
> I missed one key stroke. With this test, in a non empty current dirt, it
> fails.
>
> void KUrlCompletionTest::testInvalidProtocol()
> {
>
> KUrlCompletion* completionHomeCwd = new KUrlCompletion;
> completionHomeCwd->setDir(QUrl("/home/user"));
>
> completionHomeCwd->makeCompletion(QLatin1String(":/"));
> waitForCompletion(completionHomeCwd);
> const auto matches = completionHomeCwd->allMatches();
> // just don't crash
>
> }
Thanks for finding this. I made a copy/paste error, the "EmptyCwd" should have
been removed, there's already a completion object set up with a base dir, in
this test.
Here's the simpler test, with a fix that seems safer to me:
https://phabricator.kde.org/D11089
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D11067
To: jtamate, #frameworks, dfaure
Cc: michaelh
