chinmoyr added inline comments. INLINE COMMENTS
> dfaure wrote in slavebase.cpp:147 > That looks like horrible API ;) > A getter that optionally makes changes, based on a boolean... urgh ;) > > "Duplicating" a for loop isn't really duplication, go for a different method. Now I feel stupid for doing this. Apart from that I am not even confident about this change because it involves changes in KAuth (Obviously I am not sure about them either). How about we drop this and the related revisions for now and just delete the slave whenever there's authorization? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10641 To: chinmoyr, dfaure Cc: fvogt, #frameworks, michaelh
