aleksejshilin added inline comments. INLINE COMMENTS
> dfaure wrote in kurlnavigator.cpp:349 > Well, OK, it's not that it's *incorrect* for file:, it just seems unnecessary > to make that method call. So given that we have an if() already, why not only > do it in the else? > Well, OK, it's not that it's *incorrect* for file:, it just seems unnecessary > to make that method call. Ah, I misunderstood what you meant. > So given that we have an if() already, why not only do it in the else? Done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10993 To: aleksejshilin, #frameworks, dfaure Cc: michaelh