astippich planned changes to this revision. astippich added a comment.
In D10803#213783 <https://phabricator.kde.org/D10803#213783>, @michaelh wrote: > In D10803#213767 <https://phabricator.kde.org/D10803#213767>, @astippich wrote: > > > I don't know dolphin works, but given how KFileMetadata is designed, the new tags should be ignored until explicit support is added in dolphin. > > > Please try that. For unknown types baloo-widgets (responsible for infopanel/tooltips) falls back to `value.toString()`, no idea what will happen when you feed it with binary data. The cover properties return binary data, right? The cover is binary data, right. And I think I was wrong. While I don't fully understand yet how baloo-widgets work, from what I've read all available properties are automatically queried. The binary data would then be converted to a string as you said. So adding the cover this way may not be a good solution. A different interface should be created for image/binary data. I think I will split this into two diffs and do the cover images separately. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D10803 To: astippich, mgallien Cc: dfaure, michaelh, ngraham, #frameworks
