dfaure added inline comments. INLINE COMMENTS
> dfaure wrote in udsentrytest.cpp:235 > That's rather overkill (and a wrong use of the QUrl API). You want to use > QFileInfo for this. The comment is marked as done, but the code that was pushed still uses QUrl. > dfaure wrote in udsentrytest.cpp:269 > swap it around: what you test on the left, what you expect on the right. This > makes error messages more readable. (same above, of course) Same here, this was not fixed in the commit that was pushed. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10414 To: markg, dfaure Cc: bcooksley, apol, #frameworks, michaelh, kmorwinski
