jtamate created this revision. jtamate added reviewers: Frameworks, dfaure. Restricted Application added a project: Frameworks. jtamate requested review of this revision.
REVISION SUMMARY This summary will change when the doubts are resolved (if they can be resolved!). Implement the first part of a TODO: get rid of the raw KFileItem pointers in KCoreDirListerCache I've added a way to remove the item from the lister in findByUrl, to be modified and, if needed, added back. Questions to be answered: - In findByUrl, the dirItem->rootItem should also be removed? - fileItem is get twice in slotFileRenamed. Is this patch removing the right fileitem? - Should the fileitem removed in slotFileRenamed be added back or is it added back in emitRefreshItem? If should be added back, to which list? I know the patched code doesn't follow the original semantics because dolphin see duplicated entries while renaming takes place. TEST PLAN findByUrl is slow, for example, renaming 50.000 small files, it has to go through a list of 50.000 items 50.000 times, so renaming that number of files takes more than an hour. This patch does not improve findByUrl performance, but allows future work on it. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10742 AFFECTED FILES src/core/kcoredirlister.cpp src/core/kcoredirlister_p.h To: jtamate, #frameworks, dfaure Cc: michaelh
