dhaumann requested changes to this revision. dhaumann added a comment. This revision now requires changes to proceed.
Thanks for the contribution. Before we integrate this, would you agree to change the license to MIT? This license is preferred for new highlighting files. Also, could you please also provide a test file we can add to Autotest/input for unit testing? This file should preferably also use the MIT license. Would be nice if you provide another iteration before we commit this. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D10719 To: julianstirling, dhaumann Cc: dhaumann, ngraham, #frameworks, michaelh