sitter added a comment.

  As mentioned on IRC I think this would benefit greatly from some unit testing 
as that line check is dangerously close to requiring mental gymnastics to read. 
AT a glance, all that's needed is writing stub sudo/su helpers and a test 
asserting outcome of `SuProcess('us0r', 'PATH/fakesudo').converseSU('passwd')` 
in the given scenarios (password good su&sudo, password bad su&sudo).

REPOSITORY
  R299 KDESu

REVISION DETAIL
  https://phabricator.kde.org/D10716

To: jriddell, sitter
Cc: #frameworks, michaelh

Reply via email to