adridg added inline comments.

INLINE COMMENTS

> indexerconfig.h:42
> +     * Check if \p folder can be searched taking only
> +     * the includeFolders() into account.
> +     *

This description says only `includeFolders()` is taken into account. The next 
paragraph says "should be indexed", which suggests that the function 
`shouldBeIndexed()` is involved -- but that does a whole different set of 
checks, also using the excludes. Either rephrase to avoid the "should be 
indexed" verb here, or make more clear what exactly the criterium is.

> indexerconfig.h:47
> +     *
> +     * \return \p true if the \p folder should
> +     * be searched.

Probably `\c true`, see also D10662 <https://phabricator.kde.org/D10662>.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D10661

To: michaelh, #baloo, #dolphin, dfaure
Cc: adridg, #frameworks, michaelh

Reply via email to