kossebau added a comment.
"This (hopefully) fixes the build failure noticed in the FreeBSD (and some
linuxes)" - leaves the question: why should it exactly fix it? :)
From discussion of last week on irc, it seemed that the actual problem is
that the generated make files do not contain the dependency between the JSON
file that needs to be generated and automoc running over the cpp source file to
generate the moc file based on the referenced JSON file.
So in a highly parallel build the automoc is run before the JSON file is
generated.
Something which e.g. is tried to be solved by the code in the
`kcoreaddons_add_plugin` macro, by grepping over all the source files to find
the cpp file which references the JSON file and then create the dependency by
set_property(SOURCE ${dependent_sources} APPEND PROPERTY OBJECT_DEPENDS
${json})
Thing is that Plasma only uses the `kcoreaddons_desktop_to_json` macro, so
this is why it runs the chance to fail here, while all other projects which
create the JSON still on the fly, also call `kcoreaddons_add_plugin`, cmp.
https://lxr.kde.org/search?_filestring=&_string=kcoreaddons_add_plugin&_casesensitive=1
But not further explored, so still curious if that really is the case or if
you found the real reason.
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D10450
To: tcberner, #freebsd, mpyne, bshah, dfaure
Cc: kossebau, #frameworks, michaelh
