D10282: Use the destination KFileItem object to figure out of it's writable instead of creating a KFileItemListProperties which basically does the same thing but more expensive.

Sat, 03 Feb 2018 14:52:55 -0800 

markg created this revision.
markg added a reviewer: dfaure.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
markg requested review of this revision.

REVISION SUMMARY
  Use KFileItem::isWritable instead of the detour with KFileItemListProperties.
  It's basically the same, only more expensive.
  KFileItem::isWritable is already quite expensive on it's own.
  This saves cycles but to be fair, the amount is neglectable.

TEST PLAN
  I verified that the paste action in Dolphin (under the Right mouse button) 
still works.
  Is active (when writable) and shows the correct text as before.

REPOSITORY
  R241 KIO

BRANCH
  kfileitemproperties_optimization

REVISION DETAIL
  https://phabricator.kde.org/D10282

AFFECTED FILES
  src/widgets/paste.cpp

To: markg, dfaure
Cc: #frameworks, michaelh, ngraham

Reply via email to