michaelh added a comment.

  @broulik: My reasons for not using it
  
  1. I was a little lazy: Using all the other Qt-Objects was enough work for me 
:).
  2. I thought not using QJsonDocument was accapteble because the overall 
structure of the formatters is similar.
  
  Should you insist on QJsonDocument I'll use it of course.

INLINE COMMENTS

> lbeltrame wrote in statuscommand.cpp:122
> Small nit: space after ":".

This way one can

  ...  | cut -d ':' -f2-

otherwise you have to get rid of leading space.

> lbeltrame wrote in statuscommand.cpp:149
> What do those replace operations do?

escape double quotes

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D9958

To: michaelh, #frameworks, vhanda, smithjd, lbeltrame
Cc: broulik, ngraham

Reply via email to