mwolff added a comment.

  @rjvbb why did you request changes to proceed with this patch? The fact that 
there are more issues in KDirWatch does not mean we should hold up this 
approach.
  
  Also, please note how the fundamental issue described here affects more 
backends beside inotify, but they will need to be handled separately. There are 
a lot of O(N) iterations over the full map of watched contents, which is 
inherently a bad idea. This needs to be fixed. I added you to this review so 
that you can see how one could do it.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D9824

To: mwolff, dfaure, rjvbb, #kdevelop
Cc: markg, #frameworks

Reply via email to