apol accepted this revision. apol added inline comments. This revision is now accepted and ready to land.
INLINE COMMENTS > CMakeLists.txt:66 > > -configure_file(org.kde.kglobalaccel.service.in > - ${CMAKE_CURRENT_BINARY_DIR}/org.kde.kglobalaccel.service) > +if(WIN32) > + configure_file(org.kde.kglobalaccel.service.win.in I would add here `#we need a relocatable kglobalaccel5 executable for WIN32` REPOSITORY R268 KGlobalAccel BRANCH master REVISION DETAIL https://phabricator.kde.org/D9424 To: habacker, dfaure, bcooksley, apol Cc: apol, #frameworks